Make org.openqa.selenium.Cookie serializable #129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shs96c, I'm not familiar enough with Serializable. Can you have a look? |
|
any movement here? |
|
Sorry it took so long, but thanks for the patch! Rebased and integrated in 9936a72. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we need to store cookies in MongoDB so we need either Cookie to be serializable or to write some wrappers to perform this. As Cookie was not serializable this made us to write wrappers and use them every time we want to store cookie in MongoDB but this seems to be useless extra work so in this pull request i made Cookie serializable and wrote simple test to check, that cookie correctly serializes and deserializes.