Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split pr validate browsing context #12920

Merged
merged 15 commits into from
Oct 11, 2023
Merged

Split pr validate browsing context #12920

Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
7a0e4a9
validate-browsing-context-id
manuelsblanco Sep 3, 2023
055a381
Merge branch 'trunk' into validate-browsing-context-id
diemol Sep 4, 2023
7e29d40
[FEAT]: Introduce LogEntryUtils interface and refactor related classes
manuelsblanco Sep 8, 2023
859b263
Merge branch 'trunk' into validate-browsing-context-id
manuelsblanco Sep 8, 2023
09f5d2e
Merge branch 'trunk' into validate-browsing-context-id
manuelsblanco Sep 16, 2023
f452033
Merge branch 'trunk' into validate-browsing-context-id
titusfortner Sep 24, 2023
c5cd7ac
Merge branch 'trunk' into validate-browsing-context-id
manuelsblanco Sep 25, 2023
7d654da
Merge branch 'trunk' into validate-browsing-context-id
pujagani Sep 26, 2023
f8a5d0b
Merge branch 'SeleniumHQ:trunk' into validate-browsing-context-id
manuelsblanco Sep 26, 2023
fc09eba
Merge branch 'trunk' into validate-browsing-context-id
pujagani Sep 29, 2023
f5f2710
Modified BrowsingContext as per @pujagani suggestion
manuelsblanco Oct 5, 2023
9a4ef79
Merge branch 'trunk' into validate-browsing-context-id
pujagani Oct 6, 2023
017b05a
Merge branch 'SeleniumHQ:trunk' into validate-browsing-context-id
manuelsblanco Oct 10, 2023
dfff04d
Split the pull request as requested by @pujagani https://github.com/S…
manuelsblanco Oct 10, 2023
0462492
[java] Formatting changes
pujagani Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions java/src/org/openqa/selenium/bidi/browsingcontext/BrowsingContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ public BrowsingContext(WebDriver driver, String id) {
throw new IllegalArgumentException("WebDriver instance must support BiDi protocol");
}

Require.precondition(!id.isEmpty(), "Browsing Context id cannot be empty");

this.bidi = ((HasBiDi) driver).getBiDi();
this.id = id;
}
Expand All @@ -94,6 +96,9 @@ public BrowsingContext(WebDriver driver, WindowType type) {
public BrowsingContext(WebDriver driver, WindowType type, String referenceContextId) {
Require.nonNull("WebDriver", driver);
Require.nonNull("Reference browsing context id", referenceContextId);

Require.precondition(!referenceContextId.isEmpty(), "Reference Context id cannot be empty");

if (!(driver instanceof HasBiDi)) {
throw new IllegalArgumentException("WebDriver instance must support BiDi protocol");
}
Expand Down
Loading