Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py] implement file downloads #13023

Merged
merged 9 commits into from
Nov 1, 2023
Merged

[py] implement file downloads #13023

merged 9 commits into from
Nov 1, 2023

Conversation

titusfortner
Copy link
Member

@titusfortner titusfortner commented Oct 22, 2023

Status

The tests work when I run it locally against a grid I've started; I can't seem to get the remote tests to work with bazel locally, so it's in draft until I see if they pass on the CI. I can't figure out how to get the test/selenium/webdriver/remote/**/*.py tests to pass in the --driver. What's there "should" work. So I skipping them. But they work against 4.14.1 grid.

Description

Motivation and Context

Implements #11657

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (ee55ea2) 56.49% compared to head (a083343) 56.54%.
Report is 6 commits behind head on trunk.

❗ Current head a083343 differs from pull request most recent head 4b1b35c. Consider uploading reports for the commit 4b1b35c to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #13023      +/-   ##
==========================================
+ Coverage   56.49%   56.54%   +0.04%     
==========================================
  Files          86       86              
  Lines        5255     5281      +26     
  Branches      187      192       +5     
==========================================
+ Hits         2969     2986      +17     
- Misses       2099     2103       +4     
- Partials      187      192       +5     
Files Coverage Δ
py/selenium/webdriver/remote/command.py 100.00% <100.00%> (ø)
py/selenium/webdriver/remote/remote_connection.py 54.46% <100.00%> (+0.58%) ⬆️
py/selenium/webdriver/common/options.py 33.98% <0.00%> (-0.34%) ⬇️
py/selenium/webdriver/remote/webdriver.py 40.86% <57.89%> (+0.73%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@titusfortner titusfortner force-pushed the py_dl_files branch 4 times, most recently from 44532ab to 5b68c94 Compare October 23, 2023 03:18
@titusfortner titusfortner marked this pull request as ready for review October 23, 2023 14:15
@titusfortner
Copy link
Member Author

@AutomatedTester / @symonk I tried to add testing in the remote directory, but for some reason it wasn't recognizing the driver argument from the bazel file. /shrug

@titusfortner titusfortner force-pushed the py_dl_files branch 4 times, most recently from 4ea7207 to 4b1b35c Compare October 30, 2023 18:11
@titusfortner titusfortner merged commit 605fccd into trunk Nov 1, 2023
16 checks passed
@titusfortner titusfortner deleted the py_dl_files branch November 1, 2023 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants