[js] download files from remote server #13102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [JS] check if downlaods are enabled * [js] resolve promise before checking for names * [JS] unzip files with correct headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
In draft because downloadFile does not yet work.
@harsha509 I updated this as best I can figure, but
downloadFileis a copy/paste from ChatGPT and I'd be shocked if it worked. Can you help me figure out the right implementation for that functionality?Description
enableDownloadsgetDownloadableFilesreturns direct list of namesdownloadFIle— needs helpMotivation and Context
implement #11657