Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bidi][java] Add support for Input module (Actions) #13259

Merged
merged 9 commits into from Dec 18, 2023

Conversation

pujagani
Copy link
Contributor

@pujagani pujagani commented Dec 7, 2023

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Provide support for Input module in BiDi https://w3c.github.io/webdriver-bidi/#command-input-performActions.
The input required by BiDi and Classic is the same except when the origin is as an element, hence reused existing Actions class APIs.
The tests are the same as what we have currently for WebDriver classic except that to perform actions it uses BiDi. This will make porting easier in the future.

Motivation and Context

To start porting WebDriver Classic to WebDriver BiDi for Actions. This is the long-term motivation. Before we can port, we need to add corresponding BiDi APIs and the changes address that.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pujagani pujagani added C-java C-devtools BiDi or Chrome DevTools related issues labels Dec 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (240e17b) 57.53% compared to head (ac33eef) 57.99%.
Report is 83 commits behind head on trunk.

❗ Current head ac33eef differs from pull request most recent head dc8fada. Consider uploading reports for the commit dc8fada to get more accurate results

Files Patch % Lines
py/selenium/webdriver/safari/webdriver.py 50.00% 3 Missing ⚠️
py/selenium/webdriver/chromium/webdriver.py 83.33% 1 Missing and 1 partial ⚠️
py/selenium/webdriver/common/options.py 83.33% 1 Missing ⚠️
py/selenium/webdriver/firefox/remote_connection.py 0.00% 1 Missing ⚠️
py/selenium/webdriver/firefox/webdriver.py 83.33% 1 Missing ⚠️
py/selenium/webdriver/ie/webdriver.py 87.50% 1 Missing ⚠️
py/selenium/webdriver/remote/webdriver.py 66.66% 1 Missing ⚠️
py/selenium/webdriver/safari/service.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #13259      +/-   ##
==========================================
+ Coverage   57.53%   57.99%   +0.46%     
==========================================
  Files          86       88       +2     
  Lines        5310     5338      +28     
  Branches      221      224       +3     
==========================================
+ Hits         3055     3096      +41     
+ Misses       2034     2018      -16     
- Partials      221      224       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pujagani
Copy link
Contributor Author

The failing test is due to a timeout exception when "get" command is called. I am unable to produce it locally and not sure why is it failing only on CI.

@pujagani pujagani merged commit 060288e into SeleniumHQ:trunk Dec 18, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-devtools BiDi or Chrome DevTools related issues C-java
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants