Fix a NullPointerException in RemoteWebDriver.getCurrentUrl #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -323,7 +323,12 @@ public String getTitle() { | |||
| } | |||
|
|
|||
| public String getCurrentUrl() { | |||
| return execute(DriverCommand.GET_CURRENT_URL).getValue().toString(); | |||
| Response response = execute(DriverCommand.GET_CURRENT_URL); | |||
| if (response == null) { | |||
There was a problem hiding this comment.
can you also add || response.getValue() != null
|
also can you confirm you've signed the CLA |
execute() is allowed to return null (see line 643), which will cause a NullPointerException to be thrown in getCurrentUrl. This doesn't fix the underlying problem, but it causes it to throw a WebDriverException instead of a NullPointerException so the user can handle it in a reasonable way.
ekuefler
force-pushed
the
npe-currenturl
branch
from
5835e55
to
9fc0322
Compare
|
Addressed comment. Yes, I've signed the CLA. |
|
merged as d94c64f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
execute() is allowed to return null (see line 643), which will cause a
NullPointerException to be thrown in getCurrentUrl. This doesn't fix the
underlying problem, but it causes it to throw a WebDriverException
instead of a NullPointerException so the user can handle it in a
reasonable way.