[CI] Update logic for which tests get run #13457
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For instance I have this PR:
https://github.com/SeleniumHQ/selenium/pull/13452/commits
The GitHub Workflow evaluates as:
https://github.com/SeleniumHQ/selenium/actions/runs/7572844428/job/20623620638#step:4:7
Which you can see includes things that were added to trunk since the PR was made:
6127b5f...ac3be18
The commit getting used (
github.event.pull_request.base.sha
) is the merge commit. This PR gets the parent of that commit and uses that instead. If it isn't a PR it keeps current behavior.Example of this PR in same context:
https://github.com/SeleniumHQ/selenium/actions/runs/7574277822/job/20628303353#step:7:8
which shows just the commits we want:
6127b5f...1d44724
This has the advantage of not running extra tests based on what has been added to trunk since the PR was created and/or not requiring clicking the "update branch" button. I can't think of a scenario where this isn't what we want to do, but maybe I'm missing something?