Find visible elements #2041
Merged
Find visible elements #2041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There already was a way of finding a list of elements that are present on the page, but there was none for finding visible elements. I've created a class that makes this possible.
|
Can you also add a test for this? The pages that these tests are loading are here: |
| def __call__(self, driver): | ||
| visible_elements = [] | ||
| for element in _find_elements(driver, self.locator): | ||
| if _element_if_visible(element) is not False: |
There was a problem hiding this comment.
I think this line would be better written as:
if _element_if_visible(element):
Used in the visibility_of_all_elements tests
|
I've added the tests and replaced the call method with the list comprehension @cgoldberg mentioned. |
| self._loadPage("hidden_partially") | ||
| try: | ||
| elements = WebDriverWait(self.driver, 0.7).until(EC.visibility_of_all_elements_located((By.CLASS_NAME, "redbox"))) | ||
| except TimeoutException as e: |
There was a problem hiding this comment.
you could assert the exception is raised:
https://docs.python.org/2.7/library/unittest.html#unittest.TestCase.assertRaises
|
@cgoldberg I've changed it. I did it this way because I saw it being done in other testcases the same way. I've also made the change in this testcase |
I'm an idiot
|
awesome, thanks for the patch! (and the reworks :) ) |
AutomatedTester
pushed a commit
that referenced
this pull request
May 18, 2016
* EC for finding visible elements There already was a way of finding a list of elements that are present on the page, but there was none for finding visible elements. I've created a class that makes this possible. * Clean * Changed to list comprehension * visibility_of_all_elements tests added * Created hidden_partially.html Used in the visibility_of_all_elements tests * Now uses assertRaises * Fixed usage of assertRaises * Fixed exception name I'm an idiot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xin the preceding checkbox, I verify that I have signed the Contributor License AgreementAdds an expected conditions for finding visible elements as list. Right now this is only possible for the presence of elements.