Add 'How to build driver with phantomjs-prebuilt' #2086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Instructions for something like this in the comments above "Find Executable" function of PhantomJS In response to #2069
|
You've updated the docs on a private function. If you want this notice to be included in the generated API docs, you should add a fileoverview comment to the top of the file. For example, see selenium-webdriver/chrome.js (here are the public docs generated extracted from that file). |
|
OK. Moved the docs to the top of the file under @fileoverview. Ring me up if it still needs work |
| @@ -15,6 +15,28 @@ | |||
| // specific language governing permissions and limitations | |||
| // under the License. | |||
|
|
|||
| /** | |||
| * @fileoverview Defines a {@linkplain Driver WebDriver} client for the PhantomJS | |||
| * web browser. By default, it is expected that PhantomJS exists in your working directory. | |||
There was a problem hiding this comment.
By default, it is expected that the PhantomJS executable can be located on your
[PATH](https://en.wikipedia.org/wiki/PATH_(variable))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xin the preceding checkbox, I verify that I have signed the Contributor License AgreementAdded Instructions for something like this in the comments above "Find Executable" function of PhantomJS
In response to #2069