Interface for Select component extracted #2104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This interface will allow to create custom realisation of like-select components, which actually do not have select tag inside.
|
could somebody help me to understand what is the problem with tests? |
|
It's not the tests, you have compilation issues. First you need to add an entry in the BUCK and build.desc in the same folder. Next you should make the methods on the new interface public. |
added 2 commits
May 13, 2016 17:26
|
@lukeis Thank you for your support, I've fixed that issues, but is still fails. Sems like in a py module, but I didn't change py code, could you please take a look once more time? |
| @@ -31,6 +31,7 @@ java_library(name = "components", | |||
|
|
|||
| java_library(name = "elements", | |||
| srcs = [ | |||
| 'ISelect.java', | |||
| @@ -59,20 +59,23 @@ public Select(WebElement element) { | |||
| * @return Whether this select element support selecting multiple options at the same time? This | |||
| * is done by checking the value of the "multiple" attribute. | |||
| */ | |||
| @Override | |||
There was a problem hiding this comment.
can you revert all the Overrides added? it's not required for implementing interfaces, only overriding methods extended.
|
@lukeis overrides removed, tests passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xin the preceding checkbox, I verify that I have signed the Contributor License AgreementThis interface will allow to create custom realisation of like-select components, which actually do not have select tag inside.