GeckoDriverService should wait for the geckodriver to be running #2255
Conversation
|
@lukeis could you review please? I have done a quick look and looks good to me. |
| while (System.currentTimeMillis() < end) { | ||
| try { | ||
| Socket socket = new Socket(); | ||
| socket.connect(new InetSocketAddress("localhost", port), 1000); |
There was a problem hiding this comment.
is this the only difference between pollPort?
There was a problem hiding this comment.
@lukeis yes, and we are catching a few other Exceptions as a result of this.
There was a problem hiding this comment.
so, why not modify the other pollPort? I'm not a fan of seemingly duplicate code that does the same thing
There was a problem hiding this comment.
@lukeis The pollPort function checks if a server can be created on that port, where as this checks if the server is running so that it can be connected to. Or are you referring to some other pollPort function that I missed?
There was a problem hiding this comment.
i think you're confusing checkPortIsFree? pollPort, directly above this method does almost the same same logic.
There was a problem hiding this comment.
ah, you're right, it's trying to bind instead... i thought we had other logic... let me check
There was a problem hiding this comment.
looks like we don't... ok then :)
|
@lukeis When will the next standalone jar be released? This would be really important for making it work reliably with Geckodriver. :) |
|
¯_(ツ)_/¯ 3.0-beta will be the next release and will be done "when it's ready" By Christmas, definitely Christmas.... https://botbot.me/freenode/selenium/2016-04-29/?msg=65149334&page=4 |
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement