HubStatusServlet - use GET with query string instead of GET with body #2771
Conversation
tommywo
changed the title
tommywo
force-pushed
the
master
branch
2 times, most recently
from
da68765
to
b236b6e
Compare
|
can you make it allow both POST data and url parameter? I'm a bit concerned here about breaking people unnecessarily. |
|
I share the concerns of @lukeis -- It should continue support (although it is odd from an HTTP protocol point of view) All said, personally I'm in the opinion that the It's also worth mentioning that nodes query this servlet. |
|
It's now backward compatible with |
| @@ -101,7 +102,10 @@ private JsonObject getResponse(HttpServletRequest request) throws IOException { | |||
| if (request.getInputStream() != null) { | |||
| JsonObject requestJSON = getRequestJSON(request); | |||
| List<String> keysToReturn = null; | |||
| if (requestJSON != null && requestJSON.has("configuration")) { | |||
|
|
|||
| if (request.getParameter("configuration")!=null && !"".equals(request.getParameter("configuration"))) { | |||
There was a problem hiding this comment.
inconsistent use of whitespace here
| keys.add(URLEncoder.encode("I'm not a valid key", "UTF-8")); | ||
| keys.add(URLEncoder.encode("servlets", "UTF-8")); | ||
|
|
||
| String query = "?configuration="+String.join(",",keys); |
There was a problem hiding this comment.
inconsistent use of whitespace here
|
@mach6 done |
|
@lukeis is it ok now? can you merge? |
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement