Loosen WebElementCondition instance checks #5968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update WebElementCondition and Condition with custom static hasInstance methods so that `instanceof` checks are more lenient and don't cause issues with Babel. Fixes SeleniumHQ#5560
jleyba
requested changes
May 31, 2018
| * @param {!(IThenable<T>| | ||
| * Condition<T>| | ||
| * function(!WebDriver): T)} condition - the condition instance | ||
| * @returns {*|boolean} |
| * @returns {*|boolean} | ||
| */ | ||
| static [Symbol.hasInstance](condition) { | ||
| return condition |
There was a problem hiding this comment.
Actually, I'd probably be a little stricter:
return !!condition && typeof condition === 'object'
(plus the next two lines)
| * function(!WebDriver): T)} condition - the condition instance | ||
| * @returns {*|boolean} | ||
| */ | ||
| static [Symbol.hasInstance](condition) { |
There was a problem hiding this comment.
no need to define this a second time, it will be inherited from Condition
barancev
added a commit
that referenced
this pull request
Jan 30, 2019
This reverts commit 5ec8094. This commit was intended to fix a babel-related issue #5560. Unfortunately it broke 'x instanceof WebElementCondition' check that returns true even if 'x' is an instance of the 'Condition' class (a base class for 'WebElementCondition'). All waits that return a boolean value or a string are affected.
|
I've reverted this change by commit 6158311 because it broke The issue will be reopened too. |
shs96c
pushed a commit
to shs96c/selenium
that referenced
this pull request
Feb 18, 2019
This reverts commit 5ec8094. This commit was intended to fix a babel-related issue SeleniumHQ#5560. Unfortunately it broke 'x instanceof WebElementCondition' check that returns true even if 'x' is an instance of the 'Condition' class (a base class for 'WebElementCondition'). All waits that return a boolean value or a string are affected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update WebElementCondition and Condition with custom
static hasInstance methods so that
instanceofchecksare more lenient and don't cause issues with Babel.
Fixes #5560
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement