Remove package_data and data_files options from setup.py #5982
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
include_package_data
option set toTrue
insetup.py
, package data that is specified in MANIFEST.in is installed into the target directory when installing selenium. This means that we don't need to specifypackage_data
anddata_files
in setup.py too. With the options set as before, files were included twice in wheel distributions (once in their original place and once in the ".data" directory) and that triggered a bug that caused setuptools to fail to install the wheel distribution of selenium.I verified that running
python setup.py bdist_wheel
andpython setup.py sdist
create distributions with the data files inside and that the data files are installed when installing the created distributions.Fixes issue #5907
X
in the preceding checkbox, I verify that I have signed the Contributor License Agreement