Fix windowSize option in Firefox in Javascript #6075
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
X
in the preceding checkbox, I verify that I have signed the Contributor License AgreementHi guys.
"--window-size" is for screenshots only in Firefox, not the size of the Firefox window itself.
"--width" and "--height" are the proper way to set the dimensions of a Firefox window from the CLI.
Proof:
Works (after my change):
Doesn't work (before my change):