Added new capabilities for safari driver: automaticInspection and automaticProfiling

[email2vimalraj]

Fixes #5307

• By placing an X in the preceding checkbox, I verify that I have signed the Contributor License Agreement

[lmtierney]

Is there anywhere these are documented?

[barancev]

They are documented here:
https://webkit.org/blog/6900/webdriver-support-in-safari-10/

[barancev]

The problem is that these new capabilities don't follow W3C rules for capabilities...

[email2vimalraj]

@lmtierney @barancev I am raising this PR after a discussion on this with @shs96c during the "fix a bug be a committer" workshop that I attended two days back here in SeConf18 in Bangalore. As per my understanding I believe that some exceptions could be allowed.

@shs96c can you please chime in ?

[shs96c]

@barancev all options are added to the safari.options capability, which is unchanged for a long time.

I'm pinging Apple to try and figure out the right place to set this stuff. From the docs, it's not clear.

[shs96c]

I've had a conversation with the developer at Apple who's working most on safaridriver. Apparently, the options can be added as normal capabilities prefixed with safari:

[shs96c]

I'm tempted to merge this in and then make the fixups afterwards. Any objections from anyone?

[shs96c]

OK. My plan is to squash and merge this and then fix it up. This is a first commit from the "Fix a Bug, Become a Committer" workshop, so I'd like to thank @email2vimalraj for both attending and committing :)

[shs96c]

Congratulations on your first commit, @email2vimalraj!

[mmerrell]

+1, awesome! MM

…

Sent from my iPhone

On Jul 14, 2018, at 3:35 PM, Simon Stewart ***@***.***> wrote: Congratulations on your first commit, @email2vimalraj! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[email2vimalraj]

Thanks a lot for merging this PR. I'll try to contribute more.