Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unable to disable native events on IE driver version 3.4+ issue #6183

Merged
merged 1 commit into from Jul 24, 2018
Merged

fix unable to disable native events on IE driver version 3.4+ issue #6183

merged 1 commit into from Jul 24, 2018

Conversation

KentGu
Copy link
Contributor

@KentGu KentGu commented Jul 19, 2018

Add native events under se:ieOptions.
Add disable native events function as the native event for ie is enabled by default

Add disable native events function as the native event for ie is enabled by default
@shs96c
Copy link
Member

shs96c commented Jul 19, 2018

@KentGu, thank you for this! Not quite sure how we missed this, but it's a great catch.

Can you please confirm that you've signed the Contributor License Agreement? Once you do, I'll happily merge this in.

@shs96c shs96c added the C-java label Jul 19, 2018
@barancev
Copy link
Member

Don't we have a test for this case? Is it worth to add one?

@KentGu
Copy link
Contributor Author

KentGu commented Jul 19, 2018

@shs96c , I am not sure if ticking the checkbox is enough for signing the license agreement.

@barancev , I actually did a test on Selenium Version: 3.11.0 with IE driver version 3.3.0 also IE driver version 3.11.0. I raised a ticket on this last year 4023

@lmtierney
Copy link
Member

@KentGu we need you to sign the Contributor License Agreement before we can merge your code. The checkbox just signifies that you have done this step.

@KentGu
Copy link
Contributor Author

KentGu commented Jul 20, 2018

@lmtierney Thanks for your help. I've signed the agreement just now

@shs96c
Copy link
Member

shs96c commented Jul 24, 2018

@barancev we can add a test too.... Since @KentGu is a first time contributor, I think it best if we merge in this PR and then add the test ourselves later. I'm sure they'll add a test next time :)

@KentGu, thanks for signing the CLA, and thank you for the patch!

@shs96c shs96c merged commit d6ab55a into SeleniumHQ:master Jul 24, 2018
grigaman pushed a commit to grigaman/selenium that referenced this pull request Sep 20, 2018
Add disable native events function as the native event for ie is enabled by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants