[py] Subclass options classes from a common base class #6522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Safari options class will be added after I talk with @burg |
|
from a quick look through this looks great |
cgoldberg
reviewed
Oct 11, 2018
|
|
||
| from selenium.webdriver.common.desired_capabilities import DesiredCapabilities | ||
| from ..common.options import ArgOptions |
There was a problem hiding this comment.
any reason for the relative import instead of absolute?
There was a problem hiding this comment.
Habit, I can change it to absolute
shs96c
pushed a commit
to shs96c/selenium
that referenced
this pull request
Feb 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An ABC was used to ensure that
to_capabilitieswas implemented. This method allows us to pass just the options class toRemoteWebDriverand not have to worry about capabilities.This change is