[java] Implement equals() and hashCode() in Select element wrapper
#6617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valfirst
force-pushed
the
add-equals-hashcode-to-select
branch
from
1213fbd
to
032f28a
Compare
shs96c
reviewed
Nov 7, 2018
|
|
||
| @Override | ||
| public boolean equals(Object o) { | ||
| if (this == o) { |
There was a problem hiding this comment.
Nowadays, we tend to follow a pattern of:
if (!(o instanceof Select)) {
return false;
}
Select that = (Select) o;
return Objects.equals(this.element, that.element);
There was a problem hiding this comment.
The performance is dramatically different, but we strip more boilerplate this way.
There was a problem hiding this comment.
@shs96c updated to follow project patterns
valfirst
force-pushed
the
add-equals-hashcode-to-select
branch
from
032f28a
to
3672e66
Compare
valfirst
force-pushed
the
add-equals-hashcode-to-select
branch
from
3672e66
to
38721f8
Compare
shs96c
pushed a commit
to shs96c/selenium
that referenced
this pull request
Feb 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xin the preceding checkbox, I verify that I have signed the Contributor License AgreementThis change is