[py] Don't override browser options with desired capabilities by defa… #6814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmtierney
requested changes
Jan 4, 2019
| from selenium.webdriver.remote.webdriver import WebDriver as RemoteWebDriver | ||
| from .service import Service | ||
|
|
||
| from .options import Options |
There was a problem hiding this comment.
Can you address the flake8 error here? Then we can merge.
…ult in WebKitGTK When desired_capabilities parameter is omitted in WebKitGTK driver, the default capabilities are used. If options are also passed they are updated from desired capabilities, overriding the passed options. The desired_capabalities parameter should default to None instead.
carlosgcampos
force-pushed
the
webkitgtk-capabilities
branch
from
9d26ea8
to
26b699b
Compare
|
Merged, thank you! |
shs96c
pushed a commit
to shs96c/selenium
that referenced
this pull request
Feb 18, 2019
…ult in WebKitGTK (SeleniumHQ#6814) When desired_capabilities parameter is omitted in WebKitGTK driver, the default capabilities are used. If options are also passed they are updated from desired capabilities, overriding the passed options. The desired_capabalities parameter should default to None instead.
|
WebKitGTK is now the only browser that can't run without any options, producing an error asking about desired capabilities. Is that because of you? |
|
@bphd please file a bug report if you believe the code is not doing what it should. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ult in WebKitGTK
When desired_capabilities parameter is omitted in WebKitGTK driver, the
default capabilities are used. If options are also passed they are
updated from desired capabilities, overriding the passed options. The
desired_capabalities parameter should default to None instead.
Xin the preceding checkbox, I verify that I have signed the Contributor License AgreementThis change is