New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py] Don't override browser options with desired capabilities by defa… #6814

Merged
merged 1 commit into from Jan 4, 2019

Conversation

Projects
None yet
2 participants
@carlosgcampos
Copy link
Contributor

carlosgcampos commented Jan 4, 2019

…ult in WebKitGTK

When desired_capabilities parameter is omitted in WebKitGTK driver, the
default capabilities are used. If options are also passed they are
updated from desired capabilities, overriding the passed options. The
desired_capabalities parameter should default to None instead.


This change is Reviewable

from selenium.webdriver.remote.webdriver import WebDriver as RemoteWebDriver
from .service import Service

from .options import Options

This comment has been minimized.

@lmtierney

lmtierney Jan 4, 2019

Member

Can you address the flake8 error here? Then we can merge.

@lmtierney lmtierney added the C-py label Jan 4, 2019

[py] Don't override browser options with desired capabilities by defa…
…ult in WebKitGTK

When desired_capabilities parameter is omitted in WebKitGTK driver, the
default capabilities are used. If options are also passed they are
updated from desired capabilities, overriding the passed options. The
desired_capabalities parameter should default to None instead.

@carlosgcampos carlosgcampos force-pushed the WebKitGTK:webkitgtk-capabilities branch from 9d26ea8 to 26b699b Jan 4, 2019

@lmtierney lmtierney merged commit a920faa into SeleniumHQ:master Jan 4, 2019

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
@lmtierney

This comment has been minimized.

Copy link
Member

lmtierney commented Jan 4, 2019

Merged, thank you!

@carlosgcampos carlosgcampos deleted the WebKitGTK:webkitgtk-capabilities branch Jan 4, 2019

clarmso pushed a commit to clarmso/selenium that referenced this pull request Jan 17, 2019

[py] Don't override browser options with desired capabilities by defa…
…ult in WebKitGTK (SeleniumHQ#6814)

When desired_capabilities parameter is omitted in WebKitGTK driver, the
default capabilities are used. If options are also passed they are
updated from desired capabilities, overriding the passed options. The
desired_capabalities parameter should default to None instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment