Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to parent frame fix for non-w3c compatible drivers #7075

Merged
merged 1 commit into from
Apr 15, 2019
Merged

switch to parent frame fix for non-w3c compatible drivers #7075

merged 1 commit into from
Apr 15, 2019

Conversation

corevo
Copy link
Member

@corevo corevo commented Mar 31, 2019 •
edited by AutomatedTester

This change is Reviewable

@corevo
Copy link
Member Author

corevo commented Mar 31, 2019

@jleyba all drivers except chrome use the W3C_COMMAND_MAP and Chrome's command map doesn't have SWITCH_TO_PARENT_FRAME, not sure if that's on purpose or not.

Also if merged we'll need to release.

@jleyba jleyba merged commit 767b5c8 into master Apr 15, 2019
@corevo corevo deleted the switch-parent-frame branch May 1, 2019 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C-nodejs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@corevo @jleyba