Handles long overflow on JsonTypeCoercer #7423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that if a value is an integer, it can be safely casted to Long. Otherwise, it returns a Double. Fixes SeleniumHQ#7398
albertor24
force-pushed
the
7398-long-overflow
branch
from
b12b42a
to
a609091
Compare
|
Thanks for the PR. It makes a lot of sense, and I do like the fact that you defaulted to trying return a long. Merging now! Congratulations on your first commit, and welcome to the project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that if a value is an integer, it can be safely casted to Long. Otherwise, we would return a Double.
Fixes #7398
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement