Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] fix swapped parameter names in devtools Response model class #7468

Merged
merged 1 commit into from
Sep 10, 2019
Merged

[java] fix swapped parameter names in devtools Response model class #7468

merged 1 commit into from
Sep 10, 2019

Conversation

takeyaqa
Copy link
Contributor

@takeyaqa takeyaqa commented Aug 5, 2019

I found this at #7415 and fix swapped parameter names.

@takeyaqa
Copy link
Contributor Author

takeyaqa commented Aug 5, 2019

ref to #7413

shs96c
shs96c approved these changes Sep 10, 2019
View reviewed changes
Copy link
Member

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you!

@shs96c shs96c merged commit 53f7bf3 into SeleniumHQ:master Sep 10, 2019
@takeyaqa takeyaqa deleted the fix_devtool_response branch September 10, 2019 14:30
jimevans pushed a commit to jimevans/selenium that referenced this pull request Sep 13, 2019
@takeyaqa @jimevans
[cdp] fix Devtools Response model wrong parameter names (SeleniumHQ#7468
ed25af2 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shs96c shs96c shs96c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@takeyaqa @shs96c