Use the proxy protocol when a webdriver proxy is configured #7511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the http protocol is different between the remote selenium server and the webdriver proxy, an EPROTO error is encountered. See SeleniumHQ#7509 for more information and a reproductible test case.
|
Thank you for taking the time to contribute back! It's very much appreciated! Welcome to the project! |
|
You're welcome! We use Selenium everyday at Oui.sncf so it's with pleasure :) Thank you for the merge! |
jimevans
pushed a commit
to jimevans/selenium
that referenced
this pull request
Sep 13, 2019
…HQ#7511) When the http protocol is different between the remote selenium server and the webdriver proxy, an EPROTO error is encountered. See SeleniumHQ#7509 for more information and a reproductible test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the http protocol is different between the remote selenium
server and the webdriver proxy, an EPROTO error is encountered.
See #7509 for more information and a reproductible test case.
Could you help me to test this case correctly? It seems that changing the protocol from http to https in httpserver.js break the tests in
http_test.js. Should i create a https version ofServerand use it in a test?Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement