Fix testShouldNotScrollIfAlreadyScrolledAndElementIsInView #7603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testShouldNotScrollIfAlreadyScrolledAndElementIsInView does not work correctly. While clikcing button1, a spec-compliant implementation should scroll the page just enough to bring button1 into view, while button2 remains out of view, thus clicking button2 should cause scroll again. Reversing the order of the clicks to fix this.
|
This change is not compatible with IE driver, it scrolls to the top by default. It is not compatible with legacy FirefoxDriver too, but it's insufficient already. @jimevans What do you think about this change? Should we just ignore this test in IE? Or keep the old version of this test for IE? Or change IE driver to match the others? |
barancev
added a commit
that referenced
this pull request
Sep 26, 2019
|
I've merged this PR as 72751e8 but we need a followup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testShouldNotScrollIfAlreadyScrolledAndElementIsInView does not work
correctly. While clikcing button1, a spec-compliant implementation
should scroll the page just enough to bring button1 into view, while
button2 remains out of view, thus clicking button2 whould cause
scroll again. Reversing the order of the clicks to fix this.
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement