-
-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Edge bindings for C# and Java #820
Conversation
This is awesome. Could you please squash the commits to relevant commits only? Also have you(your employer probably) signed the cla |
@AutomatedTester I'm happy to take on getting this merged, even squashing it to a single commit myself. @petruc, let me know how you'd like to proceed. |
Thank you! I have signed the CLA. I also have approval from my employer to contribute to Selenium. Do I need anything else? I’m not a proficient github user, but I’ll try to squash the commits. Is it possible to do it from the web? From: David Burns [mailto:notifications@github.com] This is awesome. Could you please squash the commits to relevant commits only? Also have you(your employer probably) signed the clahttp://goo.gl/qC50R — |
Hi Jim, I’m not proficient with github (still learning). It would be great if you can take it from here. If you need me to address anything please do not hesitate to contact me directly petruc@microsoft.commailto:petruc@microsoft.com Thank you, From: jimevans [mailto:notifications@github.com] @AutomatedTesterhttps://github.com/AutomatedTester I'm happy to take on getting this merged, even squashing it to a single commit myself. @petruchttps://github.com/petruc, let me know how you'd like to proceed. — |
Merged in 9ed9272. Thank you very much for your contribution! |
Thank you! From: jimevans [mailto:notifications@github.com] Thank you very much for your contribution! — |
Thanks Petru, Jim! |
@sevaseva I'm gonna ask that you wait for the official Microsoft announcement of availability. That might have the answers you're wanting. |
Thanks, no worries, I will inspect the msi to find out a bit earlier than that... :) |
@petruc, @jimevans : what is the expected way to use this one within Selenium Grid? What we tried is:
$ java -jar selenium-server-standalone-2.46.0.jar -role hub
$ java -Dwebdriver.edge.driver=/path/to/EdgeDriver.exe -jar selenium-server-standalone-2.46.0.jar -role node -nodeConfig /path/to/selenium-node.json -hubHost localhost -hubPort 4444 Our selenium-node.json contains the following: {
"capabilities":
[
{
"browserName": "MicrosoftEdge",
"version": "1.0",
"maxInstances": 1,
"seleniumProtocol": "WebDriver",
"platform": "WINDOWS"
}
],
"configuration":
{
"proxy": "org.openqa.grid.selenium.proxy.DefaultRemoteProxy",
"maxSession": 1,
"register": true,
"registerCycle": 5000
}
}
final DesiredCapabilities browser = new DesiredCapabilities("MicrosoftEdge", "1.0", Platform.WINDOWS); However the node is still trying to use IE driver instead. What's wrong in what we're doing? |
The work for enabling use with grid hasn't been completed yet. You'll need to wait for a future commit. |
@jimevans ok, got it. |
@jimevans Is there any update on Edge browser with Grid |
Fix issue SeleniumHQ#820 Signed-off-by: Achim Kraus <achim.kraus@bosch-si.com>
Add MicrosoftWebDriver.exe bindings for C# and Java. The exe is available at:
http://download.microsoft.com/download/6/D/7/6D7B7A44-B792-4CB4-AEC3-4C190EB99F85/MicrosoftWebDriver.msi