Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Edge bindings for C# and Java #820

Closed
wants to merge 27 commits into from
Closed

Add Edge bindings for C# and Java #820

wants to merge 27 commits into from

Conversation

petruc
Copy link
Contributor

@petruc petruc commented Jul 22, 2015

Add MicrosoftWebDriver.exe bindings for C# and Java. The exe is available at:
http://download.microsoft.com/download/6/D/7/6D7B7A44-B792-4CB4-AEC3-4C190EB99F85/MicrosoftWebDriver.msi

petruc added 27 commits May 28, 2015 11:59
@AutomatedTester
Copy link
Member

This is awesome. Could you please squash the commits to relevant commits only?

Also have you(your employer probably) signed the cla

@jimevans
Copy link
Member

@AutomatedTester I'm happy to take on getting this merged, even squashing it to a single commit myself.

@petruc, let me know how you'd like to proceed.

@petruc
Copy link
Contributor Author

petruc commented Jul 22, 2015

Thank you!

I have signed the CLA. I also have approval from my employer to contribute to Selenium. Do I need anything else?

I’m not a proficient github user, but I’ll try to squash the commits. Is it possible to do it from the web?

From: David Burns [mailto:notifications@github.com]
Sent: Wednesday, July 22, 2015 4:11 PM
To: SeleniumHQ/selenium
Cc: Petru Cociorva
Subject: Re: [selenium] Add Edge bindings for C# and Java (#820)

This is awesome. Could you please squash the commits to relevant commits only?

Also have you(your employer probably) signed the clahttp://goo.gl/qC50R


Reply to this email directly or view it on GitHubhttps://github.com//pull/820#issuecomment-123900832.

@petruc
Copy link
Contributor Author

petruc commented Jul 22, 2015

Hi Jim,

I’m not proficient with github (still learning). It would be great if you can take it from here. If you need me to address anything please do not hesitate to contact me directly petruc@microsoft.commailto:petruc@microsoft.com

Thank you,
Petru

From: jimevans [mailto:notifications@github.com]
Sent: Wednesday, July 22, 2015 4:15 PM
To: SeleniumHQ/selenium
Cc: Petru Cociorva
Subject: Re: [selenium] Add Edge bindings for C# and Java (#820)

@AutomatedTesterhttps://github.com/AutomatedTester I'm happy to take on getting this merged, even squashing it to a single commit myself.

@petruchttps://github.com/petruc, let me know how you'd like to proceed.


Reply to this email directly or view it on GitHubhttps://github.com//pull/820#issuecomment-123901644.

@jimevans
Copy link
Member

Merged in 9ed9272.

Thank you very much for your contribution!

@jimevans jimevans closed this Jul 22, 2015
@petruc
Copy link
Contributor Author

petruc commented Jul 22, 2015

Thank you!

From: jimevans [mailto:notifications@github.com]
Sent: Wednesday, July 22, 2015 4:47 PM
To: SeleniumHQ/selenium
Cc: Petru Cociorva
Subject: Re: [selenium] Add Edge bindings for C# and Java (#820)

Merged in 9ed92729ed9272.

Thank you very much for your contribution!


Reply to this email directly or view it on GitHubhttps://github.com//pull/820#issuecomment-123909240.

@sevaseva
Copy link
Contributor

Thanks Petru, Jim!
Does the linked msi have both 32bit and 64bit exe? (the download doesn't seem to be easily find-able yet)

@jimevans
Copy link
Member

@sevaseva I'm gonna ask that you wait for the official Microsoft announcement of availability. That might have the answers you're wanting.

@sevaseva
Copy link
Contributor

Thanks, no worries, I will inspect the msi to find out a bit earlier than that... :)

@vania-pooh
Copy link
Contributor

@petruc, @jimevans : what is the expected way to use this one within Selenium Grid? What we tried is:

  1. Built the latest master into selenium-server-standalone.jar.
  2. Launched Selenium hub as usually:
$ java -jar selenium-server-standalone-2.46.0.jar -role hub
  1. Installed driver executable for Edge from Microsoft website and launched Selenium node like the following:
$ java -Dwebdriver.edge.driver=/path/to/EdgeDriver.exe -jar selenium-server-standalone-2.46.0.jar -role node -nodeConfig /path/to/selenium-node.json -hubHost localhost -hubPort 4444

Our selenium-node.json contains the following:

{
    "capabilities":
        [
            {
                "browserName": "MicrosoftEdge",
                "version": "1.0",
                "maxInstances": 1,
                "seleniumProtocol": "WebDriver",
                "platform": "WINDOWS"
            }
        ],
    "configuration":
        {
            "proxy": "org.openqa.grid.selenium.proxy.DefaultRemoteProxy",
            "maxSession": 1,
            "register": true,
            "registerCycle": 5000
        }
}
  1. After doing this we're seeing that grid console now contains one node with MicrosoftEdge browser. We're expecting it to work when specifying the following capabilities to RemoteWebDriver:
final DesiredCapabilities browser = new DesiredCapabilities("MicrosoftEdge", "1.0", Platform.WINDOWS);

However the node is still trying to use IE driver instead. What's wrong in what we're doing?

@jimevans
Copy link
Member

The work for enabling use with grid hasn't been completed yet. You'll need to wait for a future commit.

@vania-pooh
Copy link
Contributor

@jimevans ok, got it.

@mojwang
Copy link
Contributor

mojwang commented Dec 16, 2015

@jimevans @petruc any idea when JavaScript bindings for Edge will be added?

@rameshnss
Copy link

@jimevans Is there any update on Edge browser with Grid

yiming-tang-cs pushed a commit to ponder-lab/selenium that referenced this pull request Jan 2, 2020
Fix issue SeleniumHQ#820

Signed-off-by: Achim Kraus <achim.kraus@bosch-si.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants