Add Edge bindings for C# and Java #820

Closed
wants to merge 27 commits into
from

Projects

None yet

8 participants

@petruc
Contributor
petruc commented Jul 22, 2015

Add MicrosoftWebDriver.exe bindings for C# and Java. The exe is available at:
http://download.microsoft.com/download/6/D/7/6D7B7A44-B792-4CB4-AEC3-4C190EB99F85/MicrosoftWebDriver.msi

petruc added some commits May 28, 2015
@petruc petruc Edge browser bindings derived from Chrome bindings 67bfdb7
@petruc petruc Merge branch 'master' of git://github.com/SeleniumHQ/selenium 70cf0c3
@petruc petruc Merge branch 'master' of git://github.com/SeleniumHQ/selenium 06a900b
@petruc petruc Merge branch 'master' of git://github.com/SeleniumHQ/selenium 3ab382b
@petruc petruc Merge branch 'master' of git://github.com/SeleniumHQ/selenium 7cad1d9
@petruc petruc Merge branch 'master' of git://github.com/SeleniumHQ/selenium 6871fcf
@petruc petruc Merge branch 'master' of git://github.com/SeleniumHQ/selenium 130c2cb
@petruc petruc Merge branch 'master' of git://github.com/SeleniumHQ/selenium 4241c6b
@petruc petruc Merge branch 'master' of git://github.com/SeleniumHQ/selenium d6aa207
@petruc petruc Edge driver update d0b46e3
@petruc petruc Merge branch 'master' of git://github.com/SeleniumHQ/selenium 1dcf7ea
@petruc petruc Small update 2d1f783
@petruc petruc Merge branch 'master' of git://github.com/SeleniumHQ/selenium 3cf2382
@petruc petruc Merge branch 'master' of git://github.com/SeleniumHQ/selenium 45cb4c8
@petruc petruc Merge branch 'master' of git://github.com/SeleniumHQ/selenium 208f8c4
@petruc petruc Added Edge Capabilities/Options ac880c5
@petruc petruc Merge branch 'master' of git://github.com/SeleniumHQ/selenium d060ba0
@petruc petruc Clean-up Edge driver 3d9f74d
@petruc petruc Merge branch 'master' of git://github.com/SeleniumHQ/selenium 9f0cf6e
@petruc petruc Edge Java Bindings 54dcbd7
@petruc petruc Merge branch 'master' of git://github.com/SeleniumHQ/selenium 9663742
@petruc petruc Fix Comment in EdgeOptions for Java bindings 932b740
@petruc petruc Merge branch 'master' of git://github.com/SeleniumHQ/selenium a6ef055
@petruc petruc Fix comment typo 4988233
@petruc petruc Merge branch 'master' of git://github.com/SeleniumHQ/selenium 252afdf
@petruc petruc Merge branch 'master' of git://github.com/SeleniumHQ/selenium 19d1696
@petruc petruc Update download url for MicrosoftWebDriver 0fc6217
@AutomatedTester
Member

This is awesome. Could you please squash the commits to relevant commits only?

Also have you(your employer probably) signed the cla

@jimevans
Member

@AutomatedTester I'm happy to take on getting this merged, even squashing it to a single commit myself.

@petruc, let me know how you'd like to proceed.

@petruc
Contributor
petruc commented Jul 22, 2015

Thank you!

I have signed the CLA. I also have approval from my employer to contribute to Selenium. Do I need anything else?

I’m not a proficient github user, but I’ll try to squash the commits. Is it possible to do it from the web?

From: David Burns [mailto:notifications@github.com]
Sent: Wednesday, July 22, 2015 4:11 PM
To: SeleniumHQ/selenium
Cc: Petru Cociorva
Subject: Re: [selenium] Add Edge bindings for C# and Java (#820)

This is awesome. Could you please squash the commits to relevant commits only?

Also have you(your employer probably) signed the clahttp://goo.gl/qC50R


Reply to this email directly or view it on GitHubhttps://github.com/SeleniumHQ/selenium/pull/820#issuecomment-123900832.

@petruc
Contributor
petruc commented Jul 22, 2015

Hi Jim,

I’m not proficient with github (still learning). It would be great if you can take it from here. If you need me to address anything please do not hesitate to contact me directly petruc@microsoft.commailto:petruc@microsoft.com

Thank you,
Petru

From: jimevans [mailto:notifications@github.com]
Sent: Wednesday, July 22, 2015 4:15 PM
To: SeleniumHQ/selenium
Cc: Petru Cociorva
Subject: Re: [selenium] Add Edge bindings for C# and Java (#820)

@AutomatedTesterhttps://github.com/AutomatedTester I'm happy to take on getting this merged, even squashing it to a single commit myself.

@petruchttps://github.com/petruc, let me know how you'd like to proceed.


Reply to this email directly or view it on GitHubhttps://github.com/SeleniumHQ/selenium/pull/820#issuecomment-123901644.

@jimevans
Member

Merged in 9ed9272.

Thank you very much for your contribution!

@jimevans jimevans closed this Jul 22, 2015
@petruc
Contributor
petruc commented Jul 22, 2015

Thank you!

From: jimevans [mailto:notifications@github.com]
Sent: Wednesday, July 22, 2015 4:47 PM
To: SeleniumHQ/selenium
Cc: Petru Cociorva
Subject: Re: [selenium] Add Edge bindings for C# and Java (#820)

Merged in 9ed92729ed9272.

Thank you very much for your contribution!


Reply to this email directly or view it on GitHubhttps://github.com/SeleniumHQ/selenium/pull/820#issuecomment-123909240.

@sevaseva
Contributor

Thanks Petru, Jim!
Does the linked msi have both 32bit and 64bit exe? (the download doesn't seem to be easily find-able yet)

@jimevans
Member

@sevaseva I'm gonna ask that you wait for the official Microsoft announcement of availability. That might have the answers you're wanting.

@sevaseva
Contributor

Thanks, no worries, I will inspect the msi to find out a bit earlier than that... :)

@vania-pooh

@petruc, @jimevans : what is the expected way to use this one within Selenium Grid? What we tried is:

  1. Built the latest master into selenium-server-standalone.jar.
  2. Launched Selenium hub as usually:
$ java -jar selenium-server-standalone-2.46.0.jar -role hub
  1. Installed driver executable for Edge from Microsoft website and launched Selenium node like the following:
$ java -Dwebdriver.edge.driver=/path/to/EdgeDriver.exe -jar selenium-server-standalone-2.46.0.jar -role node -nodeConfig /path/to/selenium-node.json -hubHost localhost -hubPort 4444

Our selenium-node.json contains the following:

{
    "capabilities":
        [
            {
                "browserName": "MicrosoftEdge",
                "version": "1.0",
                "maxInstances": 1,
                "seleniumProtocol": "WebDriver",
                "platform": "WINDOWS"
            }
        ],
    "configuration":
        {
            "proxy": "org.openqa.grid.selenium.proxy.DefaultRemoteProxy",
            "maxSession": 1,
            "register": true,
            "registerCycle": 5000
        }
}
  1. After doing this we're seeing that grid console now contains one node with MicrosoftEdge browser. We're expecting it to work when specifying the following capabilities to RemoteWebDriver:
final DesiredCapabilities browser = new DesiredCapabilities("MicrosoftEdge", "1.0", Platform.WINDOWS);

However the node is still trying to use IE driver instead. What's wrong in what we're doing?

@jimevans
Member

The work for enabling use with grid hasn't been completed yet. You'll need to wait for a future commit.

@vania-pooh

@jimevans ok, got it.

@ddavison ddavison added the D-edge label Aug 18, 2015
@mojwang
Contributor
mojwang commented Dec 16, 2015

@jimevans @petruc any idea when JavaScript bindings for Edge will be added?

@rameshnss

@jimevans Is there any update on Edge browser with Grid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment