[javascript] Fix the syntax error preventing a test suite from running #8371

seanpoulter · 2020-05-31T05:28:55Z

Description

When I run the JavaScript tests from the HEAD of the master branch, a syntax error is reported saying the describe block does not support an async function. An example follows the PR template.

Motivation and Context

As a developer who would like to contribute to the JavaScript library, I would like the JavaScript build and tests to pass so I can make changes with confidence

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist

I have read the contributing document.
My change requires a change to the documentation. No
I have updated the documentation accordingly. Not applicable
I have added tests to cover my changes. Not applicable
All new and existing tests passed. No. The build and tests fail.
- Last failed JavaScript build - https://travis-ci.com/github/SeleniumHQ/selenium/jobs/341667142
- bazel test //javascript/node/selenium-webdriver:tests reports failures

Proposed Changes

Actual Behaviour

Suite error: [safari] finding elements
  Message:
    Error: describe expects a function argument; received [object AsyncFunction]
  Stack:
    Error: describe expects a function argument; received [object AsyncFunction]
        at <Jasmine>
        at Suite.<anonymous> (javascript/node/selenium-webdriver/test/element_finding_test.js:414:5)
        at <Jasmine>
        at javascript/node/selenium-webdriver/test/element_finding_test.js:41:3
        at javascript/node/selenium-webdriver/lib/test/index.js:49:5
        at Suite.<anonymous> (javascript/node/selenium-webdriver/testing/index.js:410:9)
        at <Jasmine>
        at Object.suite (javascript/node/selenium-webdriver/testing/index.js:392:7)
        at suite (javascript/node/selenium-webdriver/lib/test/index.js:39:11)
        at Object.<anonymous> (javascript/node/selenium-webdriver/test/element_finding_test.js:28:1)
        at Module._compile (internal/modules/cjs/loader.js:956:30)
        at Object.Module._extensions..js (internal/modules/cjs/loader.js:973:10)
        at Module.load (internal/modules/cjs/loader.js:812:32)
        at Function.Module._load (internal/modules/cjs/loader.js:724:14)
        at Module.require (internal/modules/cjs/loader.js:849:19)
        at require (internal/modules/cjs/helpers.js:74:18)
        at node_modules/jasmine/lib/jasmine.js:89:5
        at <Jasmine>
        at Jasmine.loadSpecs (node_modules/jasmine/lib/jasmine.js:88:18)
        at Jasmine.execute (node_modules/jasmine/lib/jasmine.js:257:8)
        at main (node_modules/@bazel/jasmine/src/jasmine_runner.js:188:11)
        at Object.<anonymous> (node_modules/@bazel/jasmine/src/jasmine_runner.js:210:22)
        at Module._compile (internal/modules/cjs/loader.js:956:30)
        at Object.Module._extensions..js (internal/modules/cjs/loader.js:973:10)
        at Module.load (internal/modules/cjs/loader.js:812:32)
        at Function.Module._load (internal/modules/cjs/loader.js:724:14)
        at Object.<anonymous> (javascript/node/selenium-webdriver/tests_loader.js:32:24)
        at Module._compile (internal/modules/cjs/loader.js:956:30)
        at Object.Module._extensions..js (internal/modules/cjs/loader.js:973:10)
        at Module.load (internal/modules/cjs/loader.js:812:32)
        at Function.Module._load (internal/modules/cjs/loader.js:724:14)
        at Function.Module.runMain (internal/modules/cjs/loader.js:1025:10)
        at internal/main/run_main_module.js:17:11

Suite error: [chrome] finding elements
  Message:
    Error: describe expects a function argument; received [object AsyncFunction]
  Stack:
    Error: describe expects a function argument; received [object AsyncFunction]
        at <Jasmine>
        at Suite.<anonymous> (javascript/node/selenium-webdriver/test/element_finding_test.js:414:5)
        at <Jasmine>
        at javascript/node/selenium-webdriver/test/element_finding_test.js:41:3
        at javascript/node/selenium-webdriver/lib/test/index.js:49:5
        at Suite.<anonymous> (javascript/node/selenium-webdriver/testing/index.js:410:9)
        at <Jasmine>
        at Object.suite (javascript/node/selenium-webdriver/testing/index.js:392:7)
        at suite (javascript/node/selenium-webdriver/lib/test/index.js:39:11)
        at Object.<anonymous> (javascript/node/selenium-webdriver/test/element_finding_test.js:28:1)
        at Module._compile (internal/modules/cjs/loader.js:956:30)
        at Object.Module._extensions..js (internal/modules/cjs/loader.js:973:10)
        at Module.load (internal/modules/cjs/loader.js:812:32)
        at Function.Module._load (internal/modules/cjs/loader.js:724:14)
        at Module.require (internal/modules/cjs/loader.js:849:19)
        at require (internal/modules/cjs/helpers.js:74:18)
        at node_modules/jasmine/lib/jasmine.js:89:5
        at <Jasmine>
        at Jasmine.loadSpecs (node_modules/jasmine/lib/jasmine.js:88:18)
        at Jasmine.execute (node_modules/jasmine/lib/jasmine.js:257:8)
        at main (node_modules/@bazel/jasmine/src/jasmine_runner.js:188:11)
        at Object.<anonymous> (node_modules/@bazel/jasmine/src/jasmine_runner.js:210:22)
        at Module._compile (internal/modules/cjs/loader.js:956:30)
        at Object.Module._extensions..js (internal/modules/cjs/loader.js:973:10)
        at Module.load (internal/modules/cjs/loader.js:812:32)
        at Function.Module._load (internal/modules/cjs/loader.js:724:14)
        at Object.<anonymous> (javascript/node/selenium-webdriver/tests_loader.js:32:24)
        at Module._compile (internal/modules/cjs/loader.js:956:30)
        at Object.Module._extensions..js (internal/modules/cjs/loader.js:973:10)
        at Module.load (internal/modules/cjs/loader.js:812:32)
        at Function.Module._load (internal/modules/cjs/loader.js:724:14)
        at Function.Module.runMain (internal/modules/cjs/loader.js:1025:10)
        at internal/main/run_main_module.js:17:11

Suite error: [firefox] finding elements
  Message:
    Error: describe expects a function argument; received [object AsyncFunction]
  Stack:
    Error: describe expects a function argument; received [object AsyncFunction]
        at <Jasmine>
        at Suite.<anonymous> (javascript/node/selenium-webdriver/test/element_finding_test.js:414:5)
        at <Jasmine>
        at javascript/node/selenium-webdriver/test/element_finding_test.js:41:3
        at javascript/node/selenium-webdriver/lib/test/index.js:49:5
        at Suite.<anonymous> (javascript/node/selenium-webdriver/testing/index.js:410:9)
        at <Jasmine>
        at Object.suite (javascript/node/selenium-webdriver/testing/index.js:392:7)
        at suite (javascript/node/selenium-webdriver/lib/test/index.js:39:11)
        at Object.<anonymous> (javascript/node/selenium-webdriver/test/element_finding_test.js:28:1)
        at Module._compile (internal/modules/cjs/loader.js:956:30)
        at Object.Module._extensions..js (internal/modules/cjs/loader.js:973:10)
        at Module.load (internal/modules/cjs/loader.js:812:32)
        at Function.Module._load (internal/modules/cjs/loader.js:724:14)
        at Module.require (internal/modules/cjs/loader.js:849:19)
        at require (internal/modules/cjs/helpers.js:74:18)
        at node_modules/jasmine/lib/jasmine.js:89:5
        at <Jasmine>
        at Jasmine.loadSpecs (node_modules/jasmine/lib/jasmine.js:88:18)
        at Jasmine.execute (node_modules/jasmine/lib/jasmine.js:257:8)
        at main (node_modules/@bazel/jasmine/src/jasmine_runner.js:188:11)
        at Object.<anonymous> (node_modules/@bazel/jasmine/src/jasmine_runner.js:210:22)
        at Module._compile (internal/modules/cjs/loader.js:956:30)
        at Object.Module._extensions..js (internal/modules/cjs/loader.js:973:10)
        at Module.load (internal/modules/cjs/loader.js:812:32)
        at Function.Module._load (internal/modules/cjs/loader.js:724:14)
        at Object.<anonymous> (javascript/node/selenium-webdriver/tests_loader.js:32:24)
        at Module._compile (internal/modules/cjs/loader.js:956:30)
        at Object.Module._extensions..js (internal/modules/cjs/loader.js:973:10)
        at Module.load (internal/modules/cjs/loader.js:812:32)
        at Function.Module._load (internal/modules/cjs/loader.js:724:14)
        at Function.Module.runMain (internal/modules/cjs/loader.js:1025:10)
        at internal/main/run_main_module.js:17:11

...

927 specs, 16 failures, 34 pending specs
Finished in 203.679 seconds

Proposed Behaviour

Four fewer failures. 😉

936 specs, 12 failures, 35 pending specs
Finished in 228.628 seconds

harsha509

Thank you @seanpoulter !

seanpoulter · 2020-05-31T06:55:44Z

Sorry for the force-push. I caught an old author/committer email address. 😓

seanpoulter · 2020-05-31T07:12:05Z

Any idea how to fix the build error? Looks like it might be an E instead of an e or a missing build step. 🤷 https://travis-ci.com/github/SeleniumHQ/selenium/jobs/341854655

harsha509 · 2020-05-31T07:22:24Z

Hi @seanpoulter ,

We need to build node:atoms before running the tests. Previously it was like

    ./go --verbose node:atoms
    cd javascript/node/selenium-webdriver; npm install; npm run $NPM

it was replaced recent with bazel

   bazel test //javascript/node/selenium-webdriver:tests

i think we need to also build atoms with bazel before running the tests.

Regards,
Harsha

seanpoulter · 2020-06-01T03:25:25Z

It's only one character breaking the TravisCI build. 🤦 See #8374.

seanpoulter · 2020-06-04T05:13:20Z

Thanks for updating the branch David. Now we only have 3 failures in the JavaScript build related to the relative locators. It isn't obvious to me how to fix those so I've created #8375 to discuss it (if you want help, otherwise feel free to close it).

diemol

We should merge this and iterate on the relative locators implementation in a separate PR and in the linked issue.
Thanks @seanpoulter!

seanpoulter · 2020-06-05T03:15:21Z

Thanks Diego. Who should I talk to about the relative locators? 😀

diemol · 2020-06-14T11:53:22Z

Easiest is to come to the IRC/Slack workspace, ping us in the #selenium or @selenium-tlc channels.
IRC/Slack channel

SeleniumHQ#8371) Co-authored-by: David Burns <david.burns@theautomatedtester.co.uk> Co-authored-by: Diego Molina <diemol@users.noreply.github.com>

harsha509 approved these changes May 31, 2020

View reviewed changes

[javascript] Fix the syntax error preventing a test suite from running

d42e081

AutomatedTester approved these changes Jun 3, 2020

View reviewed changes

Merge branch 'master' into fix-async-describe-block

b1f8f7e

Merge branch 'master' into fix-async-describe-block

d6b0245

diemol approved these changes Jun 4, 2020

View reviewed changes

diemol merged commit 482963e into SeleniumHQ:master Jun 4, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[javascript] Fix the syntax error preventing a test suite from running #8371

[javascript] Fix the syntax error preventing a test suite from running #8371

seanpoulter commented May 31, 2020

harsha509 left a comment

seanpoulter commented May 31, 2020

seanpoulter commented May 31, 2020

harsha509 commented May 31, 2020

seanpoulter commented Jun 1, 2020

seanpoulter commented Jun 4, 2020

diemol left a comment

seanpoulter commented Jun 5, 2020

diemol commented Jun 14, 2020

[javascript] Fix the syntax error preventing a test suite from running #8371

[javascript] Fix the syntax error preventing a test suite from running #8371

Conversation

seanpoulter commented May 31, 2020

Description

Motivation and Context

Types of changes

Checklist

Proposed Changes

Actual Behaviour

Proposed Behaviour

harsha509 left a comment

Choose a reason for hiding this comment

seanpoulter commented May 31, 2020

seanpoulter commented May 31, 2020

harsha509 commented May 31, 2020

seanpoulter commented Jun 1, 2020

seanpoulter commented Jun 4, 2020

diemol left a comment

Choose a reason for hiding this comment

seanpoulter commented Jun 5, 2020

diemol commented Jun 14, 2020