[tracing] Match client and server spans with OpenTelemetry specification #8541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…racing_http Merging latest changes from trunk.
AutomatedTester
requested changes
Jul 16, 2020
| res.getTargetHost(); | ||
| span.setAttribute("http.status_code", statusCode); | ||
|
|
||
| switch (statusCode / 100) { |
There was a problem hiding this comment.
This would be better as just status codes rather divided
There was a problem hiding this comment.
I understand your point. The division is so we can match the error code to a family of error codes rather than a particular error code. I did consider a cleaner way of doing using native java package but we don't have that dependency in the workspace. I think I can leverage existing Netty server response to make the code readable rather that using if-else.
AutomatedTester
approved these changes
Jul 17, 2020
|
This is much better without the magic numbers! |
titusfortner
pushed a commit
to titusfortner/selenium
that referenced
this pull request
Aug 13, 2020
…ion (SeleniumHQ#8541) Co-authored-by: David Burns <david.burns@theautomatedtester.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The changes are related to issue #6703. Improvises existing HTTP span error handling.
Motivation and Context
Current implementation has SpanWrapperHTTPHandler to generate spans for any request received by the server and TracedHTTPClient to generate spans for a client request. The changes help adhere to the OpenTelemetry specification to ensure consistent HTTP spans. The HTTP error code mapping with span status adheres to OpenTelemetry specification and W3C Webdriver Error Codes.
Types of changes
Checklist