[nodejs] code cleanup first iteration #9158
Conversation
potapovDim
changed the title
potapovDim
force-pushed
the
feat/code-cleanup-iteration-1
branch
from
932be4b
to
49d68e8
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Hi @potapovDim , Thanks for the PR. There are few test failures and conflicts. can you please resolve them to get this merged. Thanks, |
There was a problem hiding this comment.
Hi @potapovDim ,
Can you please resolve the conflicts and look into the failed tests?
|
@JS31096 Hey, will do, as soon as will have some free time |
|
Hi @potapovDim , Hope you're doing great. Did you get a change to look into above request ? Thanks! |
…teration-1 # Conflicts: # javascript/node/selenium-webdriver/test/chrome/devtools_test.js # javascript/node/selenium-webdriver/test/chrome/options_test.js # javascript/node/selenium-webdriver/test/lib/capabilities_test.js # javascript/node/selenium-webdriver/test/lib/logging_test.js # javascript/node/selenium-webdriver/test/lib/promise_test.js # javascript/node/selenium-webdriver/test/lib/until_test.js # javascript/node/selenium-webdriver/test/lib/webdriver_test.js
Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
|
HI @potapovDim , Thanks for the PR. I've resolved the conflicts and fixed the failed tests to get this PR merged. Thanks, |
|
Hi, @harsha509, thanks ! |
Description
Clean up code of the javascript/node/selenium-webdriver folder iteration first.
assert.deepEqual - deprecated, updated to assert.deepStrictEqual
assert.equal - deprecated, updated to assert.strictEqual
Motivation and Context
Cleanup javascript/node/selenium-webdriver folder and variables declaration aligning
Types of changes
Checklist