Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[py] PEP 484 type hints for selenium.webdriver.common.print_page_options #9608

Merged
merged 2 commits into from Jul 2, 2021
Merged

[py] PEP 484 type hints for selenium.webdriver.common.print_page_options #9608

merged 2 commits into from Jul 2, 2021

Conversation

hoefling
Copy link
Contributor

Description

This PR adds type hints to selenium.webdriver.common.print_page_options.

Motivation and Context

This is a follow-up of #9482 to address #9480.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@hoefling
[py] PEP 484 type hints for selenium.webdriver.common.print_page_options
41a1773 
Signed-off-by: oleg.hoefling <oleg.hoefling@gmail.com>
@AutomatedTester AutomatedTester merged commit e46dba5 into SeleniumHQ:trunk Jul 2, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jul 2, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@hoefling hoefling deleted the PEP-484/webdriver-common-print-page-options branch July 3, 2021 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AutomatedTester AutomatedTester AutomatedTester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hoefling @AutomatedTester