Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows None to be set for the sameSite attribute #9771

Merged

Conversation

gpt14
Copy link
Contributor

@gpt14 gpt14 commented Aug 29, 2021

Description

Allows None to be set while adding sameSite cookies

Motivation and Context

Fixes #9746

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2021

Codecov Report

Merging #9771 (724b6ed) into trunk (76683e1) will not change coverage.
The diff coverage is 75.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            trunk    #9771   +/-   ##
=======================================
  Coverage   44.50%   44.50%           
=======================================
  Files          83       83           
  Lines        5501     5501           
  Branches      249      249           
=======================================
  Hits         2448     2448           
  Misses       2804     2804           
  Partials      249      249           
Impacted Files Coverage Δ
py/selenium/webdriver/remote/webdriver.py 39.47% <0.00%> (ø)
py/selenium/__init__.py 100.00% <100.00%> (ø)
py/selenium/webdriver/__init__.py 100.00% <100.00%> (ø)
py/selenium/webdriver/ie/webdriver.py 58.97% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0101ad4...724b6ed. Read the comment docs.

@AutomatedTester AutomatedTester merged commit ee61e94 into SeleniumHQ:trunk Sep 8, 2021
@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cookies do not allow None as a value for sameSite (python bindings)
3 participants