Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Remove Edge legacy options #9908

Merged
merged 2 commits into from Oct 13, 2021

Conversation

bwalderman
Copy link
Contributor

Description

This change removes the use_chromium property from EdgeOptions, and removes a reference to the MicrosoftWebDriver (legacy) binary.

Motivation and Context

In #9166 the decision was made to remove EdgeHTML support from Selenium 4. Capabilities that were only applicable to MicrosoftWebDriver (EdgeHTML) can safely be removed. Now that Edge Chromium is the default and only supported Edge version, the use_chromium can be removed as well.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

Merging #9908 (b1da433) into trunk (c096326) will decrease coverage by 0.09%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk    #9908      +/-   ##
==========================================
- Coverage   45.04%   44.94%   -0.10%     
==========================================
  Files          83       83              
  Lines        5543     5533      -10     
  Branches      251      253       +2     
==========================================
- Hits         2497     2487      -10     
+ Misses       2795     2793       -2     
- Partials      251      253       +2     
Impacted Files Coverage Δ
py/selenium/webdriver/edge/webdriver.py 69.56% <ø> (ø)
py/selenium/webdriver/edge/options.py 52.63% <33.33%> (-16.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6cd2a8...b1da433. Read the comment docs.

@AutomatedTester AutomatedTester merged commit 87e3833 into SeleniumHQ:trunk Oct 13, 2021
@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
Co-authored-by: David Burns <david.burns@theautomatedtester.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants