[js] Fixes cdp for Chrome and Firefox #9909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pujagani
reviewed
Oct 13, 2021
| if (debuggerAddress.match(/\/se\/cdp/)) { | ||
| if (debuggerAddress.match("ws:\/\/", "http:\/\/")) { |
There was a problem hiding this comment.
These checks are not needed anymore. Just returning the debuggerAddress when it matches /se/cdp works fine with the Grid. Otherwise, the Grid complains about wrong protocol.
There was a problem hiding this comment.
Removed!
Thank you @pujagani!
AutomatedTester
approved these changes
Oct 13, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
elgatov
pushed a commit
to elgatov/selenium
that referenced
this pull request
Jun 27, 2022
* replacing targets page and browser for ff and chrome * Placing await * Updating devtools_tests * Removing extra checkes Co-authored-by: David Burns <david.burns@theautomatedtester.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
enableDebuggerfirefox option to enable debugger address which is used for CDPTypes of changes
Checklist