CMakeLists.txt: set LIB_INSTALL_DIR to /usr/local/lib which is common… #4
Conversation
|
This is only marginally better. Just drop all of these variables and use the GNUInstallDirs module shipped with CMake. |
|
Hi, oops, we're definitely using wrong directory. I aggree with @DerDakon that |
|
Thank you for the feedback. I added a commit that uses GNUInstallDirs that you could review. |
|
The idea would be to just remove the options entirely and use the variables from GNUInstallDirs, this already has code to cache those. |
slaufmann
force-pushed
the
fixLibInstallPath
branch
from
3c00c4c
to
c5eaf8b
Compare
|
I applied the approach suggested by DerDakon and squashed the changes together. The branch should be ready to merge. |
CMakeLists.txt
Outdated
| install(DIRECTORY ${INCLUDE_DIR} DESTINATION include) | ||
| install(TARGETS ${PROJECT_NAME} DESTINATION lib COMPONENT library) | ||
| install(DIRECTORY ${INCLUDE_DIR} DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}) | ||
| install(TARGETS ${PROJECT_NAME} DESTINATION lib COMPONENT ${CMAKE_INSTALL_LIBDIR}) |
There was a problem hiding this comment.
You replaced the wrong argument here.
There was a problem hiding this comment.
You're right, fixed it. Thank you.
…llDirs module. Requires CMake 2.8.5 as the module was introduced in that version.
slaufmann
force-pushed
the
fixLibInstallPath
branch
from
c5eaf8b
to
4d030c4
Compare
|
@slaufmann Thanks for your code and @DerDakon for your review! |
… among Linux systems
With the old value the *.so files got installed to /usr/local/include which is usually used for header files. A common directory for manually installed libraries is /usr/local/lib.