Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field.Input, Field.Select Get Rendered w/ Different Heights #1382

Closed
rizedr opened this issue Feb 24, 2017 · 4 comments
Closed

Field.Input, Field.Select Get Rendered w/ Different Heights #1382

rizedr opened this issue Feb 24, 2017 · 4 comments

Comments

@rizedr
Copy link

rizedr commented Feb 24, 2017

Steps

  1. Get your app running w/ CDN styles link.
  2. Put in a view a Field.Input and a Field.Select side by side in a Form.Group or a Grid.

Expected Result

The fields to have the same height.

Actual Result

There is a 1px difference between them.

Version

0.66.0

Testcase

A good place where you can view the issue is in the docs.

Looking at the library of css classes, this issue does not replicate there.

@rizedr
Copy link
Author

rizedr commented Feb 24, 2017

The line-height property seems to be different from the react library, 1.2142em, and the css library, 1.21428571em.

@levithomason
Copy link
Member

Please post CSS issues at https://github.com/Semantic-Org/Semantic-UI. This repo only concerns React components.

@rizedr
Copy link
Author

rizedr commented Feb 26, 2017

@levithomason as I stated in the first post, the issue does not replicate in the css library. ;)

@levithomason
Copy link
Member

Our CSS was simply out of date, it has been resolved by updating the SUI CSS on the doc site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants