Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal: Enter ESC should only close the top layer modal #1657

Closed
zhaoyao91 opened this issue May 6, 2017 · 1 comment
Closed

Modal: Enter ESC should only close the top layer modal #1657

zhaoyao91 opened this issue May 6, 2017 · 1 comment
Labels
bug

Comments

@zhaoyao91
Copy link

Steps

  1. open multiple modal
  2. enter ESC

Expected Result

only the top layer modal was closed

Actual Result

all modals were closed

Version

0.68.2

Testcase

https://react.semantic-ui.com/modules/modal#modal-example-multiple
@layershifter
Copy link
Member

It's same problem that in #1157, however I don't sure that it's need to be closed as dupe.

@layershifter layershifter mentioned this issue Jun 2, 2017
Merged
@layershifter layershifter changed the title Enter ESC should only close the top layer modal Modal: Enter ESC should only close the top layer modal Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zhaoyao91 @layershifter