Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render button with content and icon take about 70ms #1686

Closed
sylvain-pauly opened this issue May 18, 2017 · 2 comments
Closed

Render button with content and icon take about 70ms #1686

sylvain-pauly opened this issue May 18, 2017 · 2 comments

Comments

@sylvain-pauly
Copy link

sylvain-pauly commented May 18, 2017

Steps

Render a button with an icon named in 2 words (via props or children has the same effect) :
const example = () => <Button icon="square check" content="ON" />

Expected Result

The button with text and icon rendered in more or less than 1ms.
(A button with an icon named in one word take less than 1ms)

Actual Result

Somehow the render take about 60-70ms.

Version

0.68.3

I'm sorry but I couldn't get Perf working in codepen

@layershifter
Copy link
Member

I'm think that you meet the same problem that described in #1184. Can you check render performance of Button without an icon?

@sylvain-pauly
Copy link
Author

You're right, it's the same problem. I'll use the "className" prop instead of "name".

Thanks a lot !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants