Popup component does not clean event handlers attached to window when it unmounts

[mkarajohn]

Steps

• Have a Popup component with hideOnScroll enabled, inside a view that can get unmounted at any time (for example in the contents of a view which changes its contents based on the selected tab)
• Hover over the Popup
• Without scrolling, change the view which the Popup lived (unmount it)
• Scroll

Expected Result

I would expect the hanlePortalUnmount method of the Popup to remove the hideOnScroll method from the window's scroll event, when the Popup is unmounted. Code

Actual Result

The hideOnScroll is not removed from the window's scroll event, when the Popup is unmounted. As a result when I am in the new view and scroll, the hideOnScroll of the currently unmounted Popup will be executed and try to setState in a currently unmounted component, resulting in this error

warning.js:36 Warning: setState(...): Can only update a mounted or mounting component. This usually means you called setState() on an unmounted component. This is a no-op. Please check the code for the Popup component.

Version

Latest

[mkarajohn]

I could try opening a PR for fixing this if you think it's ok

I went ahead and opened a PR