Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal: Scrolling doesn't work properly after reopen #2150

Closed
kien8995 opened this issue Oct 2, 2017 · 1 comment · Fixed by #2152
Closed

Modal: Scrolling doesn't work properly after reopen #2150

kien8995 opened this issue Oct 2, 2017 · 1 comment · Fixed by #2152
Labels

Comments

@kien8995
Copy link

kien8995 commented Oct 2, 2017

Steps

  1. Open scroll modal
  2. Scroll modal
  3. Close scroll modal
  4. Open scroll modal again
  5. Scroll modal

Expected Result

Modal must be scrollable

Actual Result

Modal no longer scrollable

Version

0.74.2

Testcase

https://react.semantic-ui.com/modules/modal

@layershifter layershifter changed the title Docs: Scrolling Modal doesn't work properly Modal: Scrolling doesn't work properly Oct 2, 2017
@layershifter
Copy link
Member

There are no need to scroll this modal. In fact, error comes from this condition. After modal will be closed it should reset scrolling state as I think:

  handleClose = (e) => {
    debug('close()')

    const { onClose } = this.props
    if (onClose) onClose(e, this.props)

-    this.trySetState({ open: false })
+    this.trySetState({ open: false }, { scrolling: undefined })
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants