Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: local docs site is broken with React 15.6.2 #2153

Closed
ayastreb opened this issue Oct 2, 2017 · 5 comments
Closed

Docs: local docs site is broken with React 15.6.2 #2153

ayastreb opened this issue Oct 2, 2017 · 5 comments

Comments

@ayastreb
Copy link
Contributor

ayastreb commented Oct 2, 2017

Steps

  • I do a clean install (rm -rf ./node_modules/ && node install)
  • I try to run local docs site for local development
  • I run npm start as per contributing.md
  • I open http://localhost:8080/ in a browser

Expected Result

  • Local docs side is loaded

Actual Result

Looks like it happens because I have React 15.6.2 installed and cloudflare CDN doesn't have this version for some reason.
A workaround could be to lock React to 15.6.1 in package.json, e.g. "react": "15.6.1" instead of "react": "^15.6.1"
Any other ideas? 🤔

@layershifter
Copy link
Member

Use yarn? 😄 We have lockfile, so you can install deps without any problems. However, now we use three CDNs. I'm think that we can switch to jsdelivr as they have all needed deps.

@ayastreb
Copy link
Contributor Author

ayastreb commented Oct 2, 2017

Hmm, yes, maybe I should finally try using yarn. I assumed yarn and npm are interchangeable and was always too lazy to install yarn 😆

@brianespinosa
Copy link
Member

@ayastreb let us know if that worked for you. Performance is better with yarn since it caches packages locally once you've installed them. Additionally, it is just better at consistently resolving packages. Lots of great stuff in there.

@ayastreb
Copy link
Contributor Author

ayastreb commented Oct 3, 2017

@brianespinosa yes, it works with yarn, thanks!

@ayastreb ayastreb closed this as completed Oct 3, 2017
@levithomason
Copy link
Member

npm has sadly become a mess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants