Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade peer dependency to allow React 16? #2157

Closed
nwwells opened this issue Oct 3, 2017 · 1 comment
Closed

Upgrade peer dependency to allow React 16? #2157

nwwells opened this issue Oct 3, 2017 · 1 comment

Comments

@nwwells
Copy link

nwwells commented Oct 3, 2017

I'm happy to help test this more extensively, but my initial tests seem promising: that is, it doesn't just blow up.

The release announcement: https://reactjs.org/blog/2017/09/26/react-v16.0.html
Breaking changes: https://reactjs.org/blog/2017/09/26/react-v16.0.html#breaking-changes

Steps

Install the package

Expected Result

No warnings about incompatible peer dependencies

Actual Result

Warnings about incompatible peer dependencies:

warning "semantic-ui-react@0.74.2" has incorrect peer dependency "react@>=0.14.0 <= 15".
warning "semantic-ui-react@0.74.2" has incorrect peer dependency "react-dom@>=0.14.0 <= 15".

Version

semantic-ui-react@0.74.2

Testcase

N/A

@layershifter
Copy link
Member

Duplicate #2131.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants