Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup: Add z-index to popper container #4084

Closed
wants to merge 1 commit into from

Conversation

felixmosh
Copy link
Contributor

@felixmosh felixmosh commented Oct 4, 2020

fixes #4083

@felixmosh felixmosh changed the title Popup: Add z-index to popper container, fixes #4083 Bug Fix 🐛 Popup: Add z-index to popper container, fixes #4083 Oct 4, 2020
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2020

Codecov Report

Merging #4084 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4084   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files         180      180           
  Lines        3231     3231           
=======================================
  Hits         3223     3223           
  Misses          8        8           
Impacted Files Coverage Δ
src/modules/Popup/Popup.js 98.76% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fbeed9...eccf6f8. Read the comment docs.

@felixmosh felixmosh changed the title Bug Fix 🐛 Popup: Add z-index to popper container, fixes #4083 PR: Bug Fix 🐛 Popup: Add z-index to popper container, fixes #4083 Oct 4, 2020
@felixmosh felixmosh changed the title PR: Bug Fix 🐛 Popup: Add z-index to popper container, fixes #4083 Popup: Add z-index to popper container, fixes #4083 Oct 4, 2020
@felixmosh felixmosh changed the title Popup: Add z-index to popper container, fixes #4083 Popup: Add z-index to popper container Oct 4, 2020
@siarheipashkevich
Copy link

please merge this PR

@layershifter
Copy link
Member

@felixmosh thanks for contributing, however the solution with syncing zIndex from .popup is more flexible for users than a hardcoded value. I implemented it #4094 and we plan to release it on Monday. Will appreciate your eyes there 🙏

@felixmosh
Copy link
Contributor Author

Closing since #4094 fixes the same bug

@felixmosh felixmosh closed this Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popup: zIndex is not applied in v2
4 participants