Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action buttons aren't tag agnostic. #1506

Closed
dsignr opened this issue Dec 23, 2014 · 4 comments
Closed

Action buttons aren't tag agnostic. #1506

dsignr opened this issue Dec 23, 2014 · 4 comments

Comments

@dsignr
Copy link

dsignr commented Dec 23, 2014

Hi Jack, I came across this one by fluke while integrating with my app:

Consider an action button attached to an input like this (this is the syntax exactly as stated in the docs here):

<div class="ui action input">
  <input type="text" placeholder="Search...">
  <div class="ui button">Search</div>
</div>

However, when you tend to replace the div with class ui button with an input element of type submit or button, then, this breaks the site:

<div class="ui action input">
  <input type="text" placeholder="Search...">
  <input type="button" class="ui button" value="Search">    
</div>

Working version as suggested in the docs here:
http://jsfiddle.net/dsgnr/tvsu24n9/2/

Non-working version with div replaced by an input element:
http://jsfiddle.net/dsgnr/tvsu24n9/5/

I genuinely had to use the input element due to the nature of my app (Rails, minimal Ajax).

Cheers.

@jlukic
Copy link
Member

jlukic commented Dec 23, 2014

I'm on a train but this has been covered in other issues. See button does not support table-cell.

@dsignr
Copy link
Author

dsignr commented Dec 24, 2014

Ah ok, must've missed it. No worries, I'll close this issue then. Happy journey! Thanks!

@dsignr dsignr closed this as completed Dec 24, 2014
@jlukic
Copy link
Member

jlukic commented Dec 24, 2014

#793 #735

@dsignr
Copy link
Author

dsignr commented Dec 25, 2014

Ty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants