Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] Add Credit Card Validation #2729

Closed
mayhem-ahmad opened this issue Jul 26, 2015 · 4 comments
Closed

[Form] Add Credit Card Validation #2729

mayhem-ahmad opened this issue Jul 26, 2015 · 4 comments
Milestone

Comments

@mayhem-ahmad
Copy link

hey guys,

Is there a ready Credit Card Payment form validation script i need to use it in my magento store .

the reason i'm asking for this because i have the credit card form in a standalone page the don't contain prototype.js and magento validation JavaScript library .

can you please help me with this ?
Thanks!

@undercase
Copy link

No, there is not one included in the library. You must write your own using Semantic UI's form validation library.

@jlukic
Copy link
Member

jlukic commented Jul 26, 2015

I would consider a PR that adds a standard credit card validation as type: 'credit card'

@jlukic jlukic changed the title Credit Card Payment validation [Form] Add Credit Card Validation Jul 26, 2015
@sstok
Copy link

sstok commented Jul 27, 2015

@jlukic
Copy link
Member

jlukic commented Jul 27, 2015

I think the syntax should probably support specifying card type.

I.e.

// any known credit card type
type: 'credit card'
// only visa or mastercard
type: credit card[visa, mastercard]

@jlukic jlukic added this to the 2.1 milestone Jul 27, 2015
jlukic added a commit that referenced this issue Aug 13, 2015
@jlukic jlukic closed this as completed Aug 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants