Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sets border-radius when vertical buttons have a single child button #4107

Merged
merged 1 commit into from
Jul 31, 2016
Merged

Sets border-radius when vertical buttons have a single child button #4107

merged 1 commit into from
Jul 31, 2016

Conversation

Denhai
Copy link
Contributor

@Denhai Denhai commented Jun 7, 2016

Example

<div class="ui vertical buttons">
  <button class="ui button">Button</button>
</div>

fiddle
Top of the button was not rounded

@jlukic
Copy link
Member

jlukic commented Jun 26, 2016

Thanks a lot for filing this issue, and including an easy to understand test case. I've added a milestone, and will try to take a look as soon as I can.

@jlukic jlukic added this to the 2.2.1 milestone Jun 26, 2016
jlukic added a commit that referenced this pull request Jul 31, 2016
@jlukic
#4107 Fixes only one vertical button
0f48652
@jlukic jlukic merged commit 4bea7fd into Semantic-Org:next Jul 31, 2016
@jlukic jlukic mentioned this pull request Jul 31, 2016
Closed
@jlukic
Copy link
Member

jlukic commented Jul 31, 2016

I've implemented this with slightly more succinct code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Confirmed Bug
Projects
None yet
Milestone
2.2.3
Development

Successfully merging this pull request may close these issues.
2 participants
@Denhai @jlukic