Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct check for undefined variable #4544

Merged
merged 1 commit into from
Jul 11, 2017
Merged

Correct check for undefined variable #4544

merged 1 commit into from
Jul 11, 2017

Conversation

mathiasrw
Copy link
Contributor

@mathiasrw mathiasrw commented Sep 10, 2016 •
edited
Loading

The code was comparing the result of typeof with a variable named undefined.

As typeof returns a string it should compare to 'undefined'

This change is Reviewable

@mathiasrw
Correct check for undefined variable
1b0268a 
The code was comparing the result of `typeof` with a variable named `undefined`.

As typeof returns a string it should compare to `'undefined'`
@jlukic
Copy link
Member

jlukic commented Sep 13, 2016

Should be == or undefined that is indeed a mistake

@jlukic jlukic modified the milestones: 2.2, 2.2.5 Sep 13, 2016
@jlukic jlukic modified the milestones: 2.2.5, 2.2.7 Oct 28, 2016
@jlukic jlukic modified the milestones: 2.2.8, 2.2.9 Feb 21, 2017
@jlukic jlukic modified the milestones: 2.2.10, 2.2.11 Mar 28, 2017
@jlukic jlukic merged commit ba26289 into Semantic-Org:master Jul 11, 2017
@mathiasrw
Copy link
Contributor Author

👍

@mathiasrw mathiasrw deleted the patch-1 branch July 11, 2017 06:33
@layershifter layershifter mentioned this pull request Jul 11, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Confirmed Bug
Projects
None yet
Milestone
2.2.11
Development

Successfully merging this pull request may close these issues.
2 participants
@mathiasrw @jlukic