Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image size="medium" collides with name="medium" #4793

Closed
ghost opened this issue Nov 28, 2016 · 2 comments
Closed

Image size="medium" collides with name="medium" #4793

ghost opened this issue Nov 28, 2016 · 2 comments

Comments

@ghost
Copy link

ghost commented Nov 28, 2016

Please rename the Icon medium to support the medium size with other icons or reorder the position in the icon.css so, that the medium selector is defined before the other selectors.
Otherwise size="medium" will render the medium char.

Codepen
i.icon.medium:before { content: "\f23a"; }
i.icon.at:before { content: "\f1fa"; }
The medium selector was defined after the at selector and will overload them, but "medium" is not the icon. Its the size.

We use react semantic ui with semantic ui css, but this is an independent problem.

@ghost
Copy link
Author

ghost commented Dec 9, 2016

Like
#4792
I'm comming from the react semantic ui repo and posted the issue there initially, but was referred to your repo.

@stale
Copy link

stale bot commented Feb 23, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 23, 2018
@stale stale bot closed this as completed Mar 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant