-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Flag] - There are 2 hidden flags #6926
Comments
You can get Catalan flag by adding
|
Here you have an example: https://jsfiddle.net/TheJltres/9bxmc7rq/1/ |
Yeah of course, the Flag component, internally uses the "i" html tag, which uses those classes, but if you change one of those flags with the names you say "es ca" or "catalonia", doesn't work. You can try it in there: https://codesandbox.io/s/4t34j?module=/example.js&file=/example.js:160-166 |
https://codesandbox.io/s/semantic-ui-example-g5wwo I imported App.css on index.js, and added a flag with the other one. |
I did a PR in Fomantic-UI, the active fork of Semnatic-UI |
Yeah thanks, I hope they fix it soon because as you can see in the codesandbox link you provided before, console output show us the warning. |
Yes, the problem is with types of React-Semantic, now with Fomatic-UI v3 (https://github.com/fomantic/Fomantic-UI/blob/master/ROADMAP.md) will have React types also! |
This comment was marked as spam.
This comment was marked as spam.
Thank you, I've posted it in there. |
Steps to Reproduce
Expected
We must have the same exact number of flags in the flags.png sprite, which is used for the component (https://github.com/Semantic-Org/Semantic-UI/blob/master/dist/themes/default/assets/images/flags.png)
Result
Instead, we got 2 more. One of these are the Catalan (Catalonia), which you can see appearing under the Canadian flag (1st col, 36th row). I can't spot the last one.
The text was updated successfully, but these errors were encountered: