Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flag] - There are 2 hidden flags #6926

Open
rubenprodev opened this issue Jan 27, 2020 · 10 comments
Open

[Flag] - There are 2 hidden flags #6926

rubenprodev opened this issue Jan 27, 2020 · 10 comments

Comments

@rubenprodev
Copy link

Steps to Reproduce

  1. Go to https://semantic-ui.com/elements/flag.html
  2. Go to Types and see the full flag list.
  3. If you count, you get 245 flags.

Expected
We must have the same exact number of flags in the flags.png sprite, which is used for the component (https://github.com/Semantic-Org/Semantic-UI/blob/master/dist/themes/default/assets/images/flags.png)

Result
Instead, we got 2 more. One of these are the Catalan (Catalonia), which you can see appearing under the Canadian flag (1st col, 36th row). I can't spot the last one.

@TheJltres
Copy link

You can get Catalan flag by adding

i.flag.es.ca:before, i.flag.catalonia:before { background-position: 0 -936px }

@rubenprodev
Copy link
Author

It's what I already did but you get this output anyway:

Selection_003

I think they should improve it :/

@TheJltres
Copy link

TheJltres commented Jul 1, 2020

Here you have an example: https://jsfiddle.net/TheJltres/9bxmc7rq/1/

@rubenprodev
Copy link
Author

Yeah of course, the Flag component, internally uses the "i" html tag, which uses those classes, but if you change one of those flags with the names you say "es ca" or "catalonia", doesn't work. You can try it in there:

https://codesandbox.io/s/4t34j?module=/example.js&file=/example.js:160-166

@TheJltres
Copy link

https://codesandbox.io/s/semantic-ui-example-g5wwo

I imported App.css on index.js, and added a flag with the other one.

@TheJltres
Copy link

I did a PR in Fomantic-UI, the active fork of Semnatic-UI

fomantic/Fomantic-UI#1549

@rubenprodev
Copy link
Author

Yeah thanks, I hope they fix it soon because as you can see in the codesandbox link you provided before, console output show us the warning.

@TheJltres
Copy link

Yes, the problem is with types of React-Semantic, now with Fomatic-UI v3 (https://github.com/fomantic/Fomantic-UI/blob/master/ROADMAP.md) will have React types also!

@lubber-de

This comment was marked as spam.

@rubenprodev
Copy link
Author

Thank you, I've posted it in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants