Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dropdown] - allowTab tabindex value should default to select's tabindex (if exists) #7100

Open
inspector71 opened this issue Nov 26, 2022 · 2 comments

Comments

@inspector71
Copy link

inspector71 commented Nov 26, 2022

Steps to Reproduce

  1. Integrate Dropdown only via /dist/components/dropdown.min.js; /dist/components/dropdown.min.css
  2. Initialize on existing, traditional HTML select (with options etc) with an existing tabindex attribute, using ui search selection class 'triggers' and $('element').dropdown()

Expected
Dropdown created with tabindex value copied from existing select element's tabindex value.

Result
Dropdown created with tabindex="0"

Relevant line appears to be:

.attr('tabindex', 0)

@inspector71
Copy link
Author

Slapdash 'solution':

.attr('tabindex', element.attributes.tabindex.value)

No doubt for wider use requires a little more refinement. Will submit PR if/when I can :)

igABHINAV pushed a commit to igABHINAV/Semantic-UI that referenced this issue Jun 17, 2024
@igABHINAV
Copy link

Please checkout my pull request : Fixed issue #7100 : [Dropdown] - allowTab tabindex value should default to select's tabindex (if exists) #7100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants