[Modal] Fix #6198 - added check whether focused element is in a viewport

[inmylo]

I believe there is no need to restore focus to the invisible element when modal window is closed. Then there won't be cases like #6198

[y0hami]

I think this should be optional since some people might want to go back to the focused element.

[inmylo]

This PR doesn't disable going to the focused element if it is visible. But if you want add a general flag to return or not to return to the invisible element - still good for me.

[y0hami]

Ye, I think it should be an option so it doesn't change any existing behaviour.

[inmylo]

If I add new setting to the $.fn.modal.settings = { at the end of the file - will I be able to configure it both globally with:

$.fn.modal.settings.focusInvisible = false;

and for the specific modal window with:

$('.ui.modal').modal({
  focusInvisible: false,
});

?
I ask because I'm not sure whether you set/append such settings somewhere else in other files.

[y0hami]

From my knowledge the settings which are passed when calling the module override the global settings which are defined at the end of the file so yes if you do

$.fn.modal.settings.focusInvisible = false;

$('.ui.modal').modal({
  focusInvisible: true
});

The modal with .ui.modal will be true but all others will be false.

[inmylo]

Thanks for the idea, I've added needed changes. Now it is optional and enabled by default.

[inmylo]

Hello!

Can somebody merge this PR?